Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cast import paths to lowercase #138

Open
wants to merge 5 commits into
base: scip
Choose a base branch
from

Conversation

Titou325
Copy link
Contributor

@Titou325 Titou325 commented Nov 24, 2023

This is a temporary workaround for #91 until the upstream merge is completed.

@varungandhi-src
Copy link
Contributor

With this patch, there is still a difference in snapshot output on macOS,
we should fix that before landing this.

diff --git a/packages/pyright-scip/snapshots/output/nested_items/src/long_importer.py b/packages/pyright-scip/snapshots/output/nested_items/src/long_importer.py
index bc76513e4..599ecbd68 100644
--- a/packages/pyright-scip/snapshots/output/nested_items/src/long_importer.py
+++ b/packages/pyright-scip/snapshots/output/nested_items/src/long_importer.py
@@ -2,7 +2,8 @@
 #documentation (module) src.long_importer
 
 import foo.bar.baz.mod
-#      ^^^^^^^^^^^^^^^ reference  snapshot-util 0.1 `foo.bar.baz.mod`/__init__:
+#      ^^^^^^^^^^^^^^^ reference local 0
+#      documentation (module): foo.bar.baz.mod [unable to res...
 
 print(foo.bar.baz.mod.SuchNestedMuchWow)
 #^^^^ reference  python-stdlib 3.11 builtins/print().
@@ -15,6 +16,6 @@ print(foo.bar.baz.mod.SuchNestedMuchWow)
 #            >     flush: Literal[False] = False
 #            > ) -> None
 #            > ```
-#     ^^^^^^^^^^^^^^^ reference  snapshot-util 0.1 `foo.bar.baz.mod`/__init__:
+#     ^^^ reference local 0
 #                     ^^^^^^^^^^^^^^^^^ reference  snapshot-util 0.1 `src.foo.bar.baz.mod`/SuchNestedMuchWow#

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants