Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSS-24153 | Fixed type annotations in assignments not creating symbols #162

Open
wants to merge 1 commit into
base: scip
Choose a base branch
from

Conversation

ofeki-neosec
Copy link

No description provided.

Copy link
Contributor

@varungandhi-src varungandhi-src left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't had the time to look into this fully, so could you elaborate on:

  • Is this meant as a full fix for the underlying bug?
  • Is the 'TODO' meant for yourself or meant to be merged?

Additionally, could you add some tests covering different cases?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants