Extract samplingSender and use it for gRPC #637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keegancsmith
approved these changes
Aug 11, 2023
| @@ -184,3 +149,61 @@ func registerGob() { | |||
| }) | |||
| rpc.RegisterGob() | |||
| } | |||
|
|
|||
| func NewSamplingSender(next zoekt.Sender) *samplingSender { | |||
There was a problem hiding this comment.
minor: the docstring on the exported function is more useful here than on samplingSender struct.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a mismatch in performance between HTTP and gRPC, and it came down to this sampling logic. This PR extracts that sampling logic into a
Senderand reuses it for the gRPC endpoint.There are existing tests that cover the behavior of the streaming endpoint for stats-only events. I added a unit test to ensure the sampler works as I expected (though it's a little fragile to logic changes). I manually tested that the gRPC endpoint yields the same number of events as the HTTP endpoint.