grpc: port messagesize interceptors and raise default client message size to 90mb #640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does two things:
For
zoekt-sourcegraph-indexserverthe default max message size for gRPC zoekt-configuration client has been raised from 4MB to 90MB. This brings it inline with the changes in https://github.com/sourcegraph/sourcegraph/pull/55209.This ports the message size interceptors from https://github.com/sourcegraph/sourcegraph/pull/52036/ to Zoekt. Now, you can control the maximum message size that clients / servers are allowed to send/receive via the
GRPC_CLIENT_MAX_MESSAGE_SIZEandGRPC_SERVER_MAX_MESSAGE_SIZEenvironment variables.SRC_prefix has been stripped from the environment variables used here to make it suitable for more general use .