-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
grpc: add prometheus server and client prometheus metrics #642
Conversation
347ab0e
to
de3f7cb
Compare
this will be changed to point to zoekt@main once #642 is merged.
this will be changed to point to zoekt@main once sourcegraph/zoekt#642 is merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
github.com/sourcegraph/zoekt/cmd/zoekt-webserver/grpc/protos/zoekt/webserver/v1
why not one of the following
- github.com/sourcegraph/zoekt/proto
- github.com/sourcegraph/zoekt/web/proto
Nesting under cmd is a bit strange, especially for others to import. Makes somewhat sense in our monorepo, but not really for most projects.
More context: These are generating very deeply nested package names. Is that some sort of convention we are following? In the past I have just seen something simple like a proto
pkg. Personally for a small project like zoekt keeping it simple feels good to me. But if this is a convention we are wanting to follow then ignore me.
Two things: First: the package name services as a unique identifer for the service in question:
Second: In GRPC, the folder structure also must mirror the package name. The protobuf file resolution process (that compilers, Wireshark, etc. all use) depends on this folder hierarchy being correct. So between those two points, we need the |
This PR does a few things (each commit is independently reviewable)
buf lint
never` worked properly on this package. I also went ahead and fixed all the lint complaints.See https://github.com/sourcegraph/sourcegraph/pull/56525 for a screenshot of what the new zoekt-webserver gRPC dashboards look like in sourcegraph.