Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grpc: zoekt-sourcegraph-indexserer: enable by default, support reading from SG_FEATURE_FLAG_GRPC #650

Merged
merged 2 commits into from
Sep 18, 2023
Merged

grpc: zoekt-sourcegraph-indexserer: enable by default, support reading from SG_FEATURE_FLAG_GRPC #650

merged 2 commits into from
Sep 18, 2023

Conversation

ggilmore
Copy link
Contributor

This PR does two things:

  • It enables using gRPC by default in the client that zoekt-sourcegraph-indexserver uses to communicate with Sourcegraph's internal API
  • It adds support for being able to use the SG_FEATURE_FLAG_GRPC environment variable in addition to GRPC_ENABLED to enable gRPC for zoekt-sourcegraph-indexserver. This makes it so that we can use the same environment variable (SG_FEATURE_FLAG_GRPC) to toggle gRPC on and off in all Sourcegraph services.

Test plan: Unit tests

@ggilmore ggilmore requested review from camdencheek and a team September 18, 2023 18:21
@ggilmore ggilmore merged commit 2011bba into main Sep 18, 2023
8 checks passed
@ggilmore ggilmore deleted the zoekt-grpc-default branch September 18, 2023 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camdencheek camdencheek camdencheek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ggilmore @camdencheek