Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Queue.init #808

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Remove Queue.init #808

merged 1 commit into from
Aug 20, 2024

Conversation

jtibshirani
Copy link
Member

Queue is always created through NewQueue, which always initializes the data
structures. So we don't need to initialize them in other methods.

@cla-bot cla-bot bot added the cla-signed label Aug 19, 2024
@jtibshirani jtibshirani force-pushed the jtibs/queue branch 3 times, most recently from bc5895a to 3bd3e46 Compare August 20, 2024 08:15
@jtibshirani jtibshirani marked this pull request as ready for review August 20, 2024 08:22
@jtibshirani jtibshirani requested a review from a team August 20, 2024 08:22
@jtibshirani jtibshirani merged commit aea6871 into main Aug 20, 2024
9 checks passed
@jtibshirani jtibshirani deleted the jtibs/queue branch August 20, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanhengl stefanhengl stefanhengl approved these changes

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jtibshirani @stefanhengl