eval: simplify query.RawConfig #833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While working on scoring I noticed that public repos always have an advantage compared to private repos, because we have `doc(rawConfig:RcOnlyPublic|...)` as part of the matchtree, which contributues +1 to the atom count. Test plan: New unit test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on scoring I noticed that public repos always have an advantage compared to private repos. The reason is that we have
doc(rawConfig:RcOnlyPublic|...)as part of the match tree, which contributes +1 to the atom count.For compound shards this won't help because we will likely have a mix of public and private repos, but this is still a good optimization to have in general.
Test plan:
New unit test