Fix segmentation fault on describing objects failures in test (#190)

Signed-off-by: Juan Cruz Viotti <[email protected]>

src/command_test.cc

@@ -241,13 +241,12 @@ auto sourcemeta::jsonschema::cli::test(
         return EXIT_FAILURE;
       }
 
+      const auto instance{
+          get_data(test_case, entry.first.parent_path(), verbose)};
       const std::string ref{"$ref"};
-      sourcemeta::blaze::ErrorTraceOutput output{schema.value(),
-                                                 {std::cref(ref)}};
+      sourcemeta::blaze::ErrorTraceOutput output{instance, {std::cref(ref)}};
       const auto case_result{sourcemeta::blaze::evaluate(
-          schema_template,
-          get_data(test_case, entry.first.parent_path(), verbose),
-          std::ref(output))};
+          schema_template, instance, std::ref(output))};
 
       std::ostringstream test_case_description;
       if (test_case.defines("description")) {

test/CMakeLists.txt

@@ -79,6 +79,7 @@ add_jsonschema_test_unix(metaschema/pass_single)
 add_jsonschema_test_unix(metaschema/pass_2020_12)
 
 # Test
+add_jsonschema_test_unix(test/fail_additional_properties)
 add_jsonschema_test_unix(test/fail_true_single_resolve)
 add_jsonschema_test_unix(test/fail_true_single_resolve_verbose)
 add_jsonschema_test_unix(test/fail_false_single_resolve)

test/test/fail_additional_properties.sh

@@ -0,0 +1,41 @@
+#!/bin/sh
+
+set -o errexit
+set -o nounset
+
+TMP="$(mktemp -d)"
+clean() { rm -rf "$TMP"; }
+trap clean EXIT
+
+cat << 'EOF' > "$TMP/schema.json"
+{
+  "id": "https://example.com",
+  "$schema": "http://json-schema.org/draft-04/schema#",
+  "type": "object",
+  "additionalProperties": false,
+  "properties": {
+    "foo": true,
+    "bar": true
+  }
+}
+EOF
+
+cat << 'EOF' > "$TMP/test.json"
+{
+  "target": "https://example.com",
+  "tests": [
+    {
+      "valid": false,
+      "data": { "fo": true }
+    }
+  ]
+}
+EOF
+
+"$1" test "$TMP/test.json" --resolve "$TMP/schema.json" 1> "$TMP/output.txt" 2>&1
+
+cat << EOF > "$TMP/expected.txt"
+$(realpath "$TMP")/test.json: PASS 1/1
+EOF
+
+diff "$TMP/output.txt" "$TMP/expected.txt"

test/test/fail_multi_resolve.sh

@@ -52,7 +52,7 @@ $(realpath "$TMP")/test.json:
   2/4 FAIL First failure
 
 error: Schema validation failure
-  The value was expected to be of type string but it was of type object
+  The value was expected to be of type string but it was of type integer
     at instance location ""
     at evaluate path "/type"
 

test/test/fail_multi_resolve_verbose.sh

@@ -54,7 +54,7 @@ $(realpath "$TMP")/test.json:
   2/4 FAIL First failure
 
 error: Schema validation failure
-  The value was expected to be of type string but it was of type object
+  The value was expected to be of type string but it was of type integer
     at instance location ""
     at evaluate path "/type"
 

test/test/fail_true_resolve_fragment.sh

@@ -40,7 +40,7 @@ $(realpath "$TMP")/test.json:
   1/1 FAIL Fail
 
 error: Schema validation failure
-  The value was expected to be of type string but it was of type object
+  The value was expected to be of type string but it was of type integer
     at instance location ""
     at evaluate path "/type"
 EOF

test/test/fail_true_single_resolve.sh

@@ -47,7 +47,7 @@ $(realpath "$TMP")/test.json:
   2/3 FAIL Unexpected
 
 error: Schema validation failure
-  The value was expected to be of type string but it was of type object
+  The value was expected to be of type string but it was of type integer
     at instance location ""
     at evaluate path "/type"
 EOF

test/test/fail_true_single_resolve_verbose.sh

@@ -49,7 +49,7 @@ $(realpath "$TMP")/test.json:
   2/3 FAIL Unexpected
 
 error: Schema validation failure
-  The value was expected to be of type string but it was of type object
+  The value was expected to be of type string but it was of type integer
     at instance location ""
     at evaluate path "/type"