Better implement human friendly validate error messages

DEPENDENCIES

@@ -1,3 +1,3 @@
 vendorpull https://github.com/sourcemeta/vendorpull dea311b5bfb53b6926a4140267959ae334d3ecf4
 noa https://github.com/sourcemeta/noa 5ff4024902642afc9cc2f9a9e02ae9dff9d15d4f
-jsontoolkit https://github.com/sourcemeta/jsontoolkit dc7e1e21853f2b26cac572d5dc4c3dc50eeda935
+jsontoolkit https://github.com/sourcemeta/jsontoolkit 2775ccc05af7be64dd2532694bb17274185aeec1

src/utils.cc

@@ -101,20 +101,23 @@ auto parse_options(const std::span<const std::string> &arguments,
 
 auto pretty_evaluate_callback(
     bool result,
-    const sourcemeta::jsontoolkit::SchemaCompilerTemplate::value_type &,
+    const sourcemeta::jsontoolkit::SchemaCompilerTemplate::value_type &step,
     const sourcemeta::jsontoolkit::Pointer &evaluate_path,
     const sourcemeta::jsontoolkit::Pointer &instance_location,
+    const sourcemeta::jsontoolkit::JSON &,
     const sourcemeta::jsontoolkit::JSON &) -> void {
   if (result) {
     return;
   }
 
-  // TODO: Improve this pretty terrible output
-  std::cerr << "✗ \"";
+  std::cerr << "error: " << sourcemeta::jsontoolkit::describe(step) << "\n";
+  std::cerr << "    at instance location \"";
   sourcemeta::jsontoolkit::stringify(instance_location, std::cerr);
-  std::cerr << "\" at evaluate path (\"";
+  std::cerr << "\"\n";
+
+  std::cerr << "    at evaluate path \"";
   sourcemeta::jsontoolkit::stringify(evaluate_path, std::cerr);
-  std::cerr << "\")\n";
+  std::cerr << "\"\n";
 }
 
 auto resolver(const std::map<std::string, std::vector<std::string>> &options)

src/utils.h

@@ -2,6 +2,7 @@
 #define INTELLIGENCE_JSONSCHEMA_CLI_UTILS_H_
 
 #include <sourcemeta/jsontoolkit/json.h>
+#include <sourcemeta/jsontoolkit/jsonpointer.h>
 #include <sourcemeta/jsontoolkit/jsonschema.h>
 
 #include <filesystem> // std::filesystem
@@ -37,6 +38,7 @@ auto pretty_evaluate_callback(
     const sourcemeta::jsontoolkit::SchemaCompilerTemplate::value_type &,
     const sourcemeta::jsontoolkit::Pointer &evaluate_path,
     const sourcemeta::jsontoolkit::Pointer &instance_location,
+    const sourcemeta::jsontoolkit::JSON &,
     const sourcemeta::jsontoolkit::JSON &) -> void;
 
 auto resolver(const std::map<std::string, std::vector<std::string>> &options)

test/validate_fail.sh

@@ -11,6 +11,7 @@ trap clean EXIT
 cat << 'EOF' > "$TMP/schema.json"
 {
   "$schema": "http://json-schema.org/draft-04/schema#",
+  "type": "object",
   "properties": {
     "foo": {
       "type": "string"