fix: Limit badger iterator seek to iterator bounds #47
+192
−349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewSisley
force-pushed
the
38-badger-seek-beyond-iter
branch
from
ebdd67b to
765b33b
Compare
Fixing now, as it is quick, and it gets in the way of the primary change coming in a later commit.
AndrewSisley
force-pushed
the
38-badger-seek-beyond-iter
branch
from
765b33b to
d1573f2
Compare
nasdf
approved these changes
Feb 3, 2025
badger/iter.go
Outdated
|
|
||
| if !it.i.Valid() { | ||
| // `it.i.Next()` will panic if we attempt to call it having already reached | ||
| // the iterator end, so we much return before trying to make that call if we can. |
There was a problem hiding this comment.
:) I am introducing way too many typos atm, thanks Keenan
- Fix typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Resolves #38
Resolves #19
Description
Limit badger iterator seek to iterator bounds.
Also fixes a panic when calling badger.Next, and simplifies the badger iterator code.