Skip to content

Commit

Permalink
fix(i): Server dump fails (#2374)
Browse files Browse the repository at this point in the history
## Relevant issue(s)

Resolves #2373 

## Description

This PR fixes an issue that caused the server dump command to use the in
memory store incorrectly and fail.

## Tasks

- [x] I made sure the code is well commented, particularly
hard-to-understand areas.
- [x] I made sure the repository-held documentation is changed
accordingly.
- [x] I made sure the pull request title adheres to the conventional
commit style (the subset used in the project can be found in
[tools/configs/chglog/config.yml](tools/configs/chglog/config.yml)).
- [x] I made sure to discuss its limitations such as threats to
validity, vulnerability to mistake and misuse, robustness to
invalidation of assumptions, resource requirements, ...

## How has this been tested?

manually `defradb server-dump`

Specify the platform(s) on which this was tested:
- MacOS
  • Loading branch information
nasdf authored Mar 5, 2024
1 parent a6e886e commit 002f522
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion cli/server_dump.go
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ func MakeServerDumpCmd() *cobra.Command {
}
storeOpts := []node.StoreOpt{
node.WithPath(cfg.GetString("datastore.badger.path")),
node.WithInMemory(cfg.GetString("datastore.store") != configStoreMemory),
}
rootstore, err := node.NewStore(storeOpts...)
if err != nil {
Expand Down

0 comments on commit 002f522

Please sign in to comment.