Skip to content

Commit

Permalink
Remove completed todo
Browse files Browse the repository at this point in the history
  • Loading branch information
AndrewSisley committed Jun 10, 2024
1 parent 343b90a commit 21839d2
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ import (
testUtils "github.com/sourcenetwork/defradb/tests/integration"
)

// TODO: Don't return grouped field if not selected. [https://github.com/sourcenetwork/defradb/issues/1582].
func TestQueryOneToManyWithParentGroupByOnRelatedTypeFromManySideUsingAlias(t *testing.T) {
test := testUtils.RequestTestCase{

Expand Down Expand Up @@ -162,7 +161,6 @@ func TestQueryOneToManyWithParentGroupByOnRelatedTypeFromManySideUsingAlias(t *t
executeTestCase(t, test)
}

// TODO: Don't return grouped field if not selected. [https://github.com/sourcenetwork/defradb/issues/1582].
func TestQueryOneToManyWithParentGroupByOnRelatedTypeFromManySideUsingAliasAndRelatedSelection(t *testing.T) {
test := testUtils.RequestTestCase{

Expand Down Expand Up @@ -626,7 +624,6 @@ func TestQueryOneToManyWithParentGroupByOnRelatedTypeWithIDSelectionFromManySide
executeTestCase(t, test)
}

// TODO: Don't return grouped field if not selected. [https://github.com/sourcenetwork/defradb/issues/1582].
func TestQueryOneToManyWithParentGroupByOnRelatedTypeFromSingleSideUsingAlias(t *testing.T) {
test := testUtils.RequestTestCase{
Description: "One-to-many query with groupBy on related id field alias (from single side).",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ import (
testUtils "github.com/sourcenetwork/defradb/tests/integration"
)

// TODO: Don't return grouped field if not selected. [https://github.com/sourcenetwork/defradb/issues/1582].
func TestQueryOneToManyWithParentGroupByOnRelatedTypeIDFromManySide(t *testing.T) {
test := testUtils.RequestTestCase{
Description: "One-to-many query with groupBy on related id (from many side).",
Expand Down Expand Up @@ -301,7 +300,6 @@ func TestQueryOneToManyWithParentGroupByOnRelatedTypeIDWithIDSelectionFromManySi
executeTestCase(t, test)
}

// TODO: Don't return grouped field if not selected. [https://github.com/sourcenetwork/defradb/issues/1582].
func TestQueryOneToManyWithParentGroupByOnRelatedTypeFromSingleSide(t *testing.T) {
test := testUtils.RequestTestCase{
Description: "One-to-many query with groupBy on related id (from single side).",
Expand Down

0 comments on commit 21839d2

Please sign in to comment.