Skip to content

Commit

Permalink
PR: Fix the v3 -> v4 upload/download merging
Browse files Browse the repository at this point in the history
  • Loading branch information
shahzadlone committed Jun 26, 2024
1 parent 06f49e9 commit 5df464f
Showing 1 changed file with 15 additions and 1 deletion.
16 changes: 15 additions & 1 deletion .github/workflows/test-and-upload-coverage.yml
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,17 @@ jobs:
if: ${{ !matrix.detect-changes }}
uses: actions/upload-artifact@v4
with:
name: ${{ matrix.os }}_${{ matrix.client-type }}_${{ matrix.database-type }}_${{ matrix.mutation-type }}
# Make sure the name is always unique per job as artifacts are now immutable.
# Note Issue: https://github.com/actions/upload-artifact/issues/478
# Solve: https://github.com/actions/upload-artifact/issues/478#issuecomment-1885470013
name: "coverage\
_${{ matrix.os }}\
_${{ matrix.client-type }}\
_${{ matrix.database-type }}\
_${{ matrix.mutation-type }}\
_${{ matrix.lens-type }}\
_${{ matrix.database-encryption }}\
"
path: coverage.txt
if-no-files-found: error
retention-days: 7
Expand All @@ -191,6 +201,10 @@ jobs:
- name: Download coverage reports
uses: actions/download-artifact@v4
with:
pattern: coverage_*
# Note: https://github.com/actions/download-artifact/blob/main/docs/MIGRATION.md
# Solve: https://github.com/actions/upload-artifact/issues/478#issuecomment-1885470013
merge-multiple: true
path: coverage_reports

- name: Upload coverage to Codecov
Expand Down

0 comments on commit 5df464f

Please sign in to comment.