make all array kinds nillable

sourcenetwork · Apr 19, 2024 · 8a71b16 · 8a71b16
1 parent 734b326
commit 8a71b16
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 5 deletions.
diff --git a/client/normal_nil.go b/client/normal_nil.go
@@ -34,13 +34,13 @@ func NewNormalNil(kind FieldKind) (NormalValue, error) {
 		return NewNormalNillableString(immutable.None[string]()), nil
 	case FieldKind_NILLABLE_BLOB:
 		return NewNormalNillableBytes(immutable.None[[]byte]()), nil
-	case FieldKind_NILLABLE_BOOL_ARRAY:
+	case FieldKind_BOOL_ARRAY, FieldKind_NILLABLE_BOOL_ARRAY:
 		return NewNormalBoolNillableArray(immutable.None[[]bool]()), nil
-	case FieldKind_NILLABLE_INT_ARRAY:
+	case FieldKind_INT_ARRAY, FieldKind_NILLABLE_INT_ARRAY:
 		return NewNormalIntNillableArray(immutable.None[[]int64]()), nil
-	case FieldKind_NILLABLE_FLOAT_ARRAY:
+	case FieldKind_FLOAT_ARRAY, FieldKind_NILLABLE_FLOAT_ARRAY:
 		return NewNormalFloatNillableArray(immutable.None[[]float64]()), nil
-	case FieldKind_NILLABLE_STRING_ARRAY:
+	case FieldKind_STRING_ARRAY, FieldKind_NILLABLE_STRING_ARRAY:
 		return NewNormalStringNillableArray(immutable.None[[]string]()), nil
 	default:
 		return nil, NewCanNotMakeNormalNilFromFieldKind(kind)

diff --git a/client/schema_field_description.go b/client/schema_field_description.go
@@ -154,7 +154,11 @@ func (k ScalarArrayKind) Underlying() string {
 }
 
 func (k ScalarArrayKind) IsNillable() bool {
-	return k == FieldKind_NILLABLE_BOOL_ARRAY ||
+	return k == FieldKind_BOOL_ARRAY ||
+		k == FieldKind_INT_ARRAY ||
+		k == FieldKind_FLOAT_ARRAY ||
+		k == FieldKind_STRING_ARRAY ||
+		k == FieldKind_NILLABLE_BOOL_ARRAY ||
 		k == FieldKind_NILLABLE_INT_ARRAY ||
 		k == FieldKind_NILLABLE_FLOAT_ARRAY ||
 		k == FieldKind_NILLABLE_STRING_ARRAY