fix: Mark docs as deleted when querying in delete mut (#2298)

## Relevant issue(s) Resolves #1846 ## Description Marks docs as deleted when querying _deleted in delete mutation.
sourcenetwork · Feb 8, 2024 · ea511f0 · ea511f0
1 parent 89efbc4
commit ea511f0
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/planner/delete.go b/planner/delete.go
@@ -57,6 +57,10 @@ func (n *deleteNode) Next() (bool, error) {
 	if err != nil {
 		return false, err
 	}
+
+	n.currentValue.Status = client.Deleted
+	n.documentMapping.TrySetFirstOfName(&n.currentValue, request.DeletedFieldName, true)
+
 	return true, nil
 }
 

diff --git a/tests/integration/mutation/delete/with_deleted_field_test.go b/tests/integration/mutation/delete/with_deleted_field_test.go
@@ -16,8 +16,6 @@ import (
 	testUtils "github.com/sourcenetwork/defradb/tests/integration"
 )
 
-// This test documents a bug, see:
-// https://github.com/sourcenetwork/defradb/issues/1846
 func TestMutationDeletion_WithDeletedField(t *testing.T) {
 	test := testUtils.TestCase{
 		Actions: []any{
@@ -43,8 +41,7 @@ func TestMutationDeletion_WithDeletedField(t *testing.T) {
 					}`,
 				Results: []map[string]any{
 					{
-						// This should be true, as it has been deleted.
-						"_deleted": false,
+						"_deleted": true,
 						"_docID":   "bae-decf6467-4c7c-50d7-b09d-0a7097ef6bad",
 					},
 				},