fix lint and hanging listener in test

sourcenetwork · Mar 8, 2024 · f4bec70 · f4bec70
1 parent 30c6eab
commit f4bec70
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/http/server_test.go b/http/server_test.go
@@ -113,6 +113,8 @@ func TestServerListenAndServeWithTLSAndInvalidCerts(t *testing.T) {
 	require.NoError(t, err)
 	err = srv.Serve()
 	require.ErrorContains(t, err, "no such file or directory")
+	err = srv.listener.Close()
+	require.NoError(t, err)
 }
 
 func TestServerListenAndServeWithAddress(t *testing.T) {

diff --git a/node/node.go b/node/node.go
@@ -12,6 +12,7 @@ package node
 
 import (
 	"context"
+	"errors"
 	"fmt"
 	gohttp "net/http"
 
@@ -167,7 +168,7 @@ func (n *Node) Start(ctx context.Context) error {
 		}
 		log.FeedbackInfo(ctx, fmt.Sprintf("Providing HTTP API at %s.", n.Server.Address()))
 		go func() {
-			if err := n.Server.Serve(); err != nil && err != gohttp.ErrServerClosed {
+			if err := n.Server.Serve(); err != nil && !errors.Is(err, gohttp.ErrServerClosed) {
 				log.FeedbackErrorE(ctx, "HTTP server stopped", err)
 			}
 		}()