-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools: Add Akash deployment configuration #1736
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
@@ Coverage Diff @@
## develop #1736 +/- ##
===========================================
- Coverage 75.79% 75.73% -0.05%
===========================================
Files 209 209
Lines 22064 22064
===========================================
- Hits 16722 16710 -12
- Misses 4191 4200 +9
- Partials 1151 1154 +3
Flags with carried forward coverage won't be shown. Click here to find out more. see 6 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
- "akash1365yvmc4s7awdyj3n2sav7xfx76adc6dnmlx63" | ||
- "akash18qa2a2ltfyvkyj0ggj3hkvuj6twzyumuaru9s4" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: Where are these signatures from?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I asked for clarification on these in the Akash discord.
akash1365yvmc4s7awdyj3n2sav7xfx76adc6dnmlx63
Akash community auditsakash18qa2a2ltfyvkyj0ggj3hkvuj6twzyumuaru9s4
moultrie-audits
There is no official registry for Akash audit addresses and these two seem to appear in most Akash configs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks alright, however I don't know much about Akash configs haha, is there a test run for this? Or list of steps I can take to test it myself?
Todos:
- This seems like a
tools
type of pr than a defradb feature. - Maybe a bit more descriptive PR title. i.e.
tools: Add Akash deployment configuration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, added a quick/optional suggestion to the readme
The process requires creating an Akash account, setting up a certificate, and having at a minimum 5 AKT. I believe we are going to add a guide to our documentation. I'm happy to do a walkthrough for anyone interested. |
## Relevant issue(s) Resolves sourcenetwork#1659 Resolves sourcenetwork#1378 ## Description This PR adds an Akash deployment template to DefraDB `tools/cloud/akash`. Akash deployment URI: http://0i8se95qgletbeq16atqulhhc8.ingress.midwesternwireless.com/api/v0 ## Tasks - [x] I made sure the code is well commented, particularly hard-to-understand areas. - [x] I made sure the repository-held documentation is changed accordingly. - [x] I made sure the pull request title adheres to the conventional commit style (the subset used in the project can be found in [tools/configs/chglog/config.yml](tools/configs/chglog/config.yml)). - [x] I made sure to discuss its limitations such as threats to validity, vulnerability to mistake and misuse, robustness to invalidation of assumptions, resource requirements, ... ## How has this been tested? Manual deployment via Cloudmos. Specify the platform(s) on which this was tested: N/A
Relevant issue(s)
Resolves #1659
Resolves #1378
Description
This PR adds an Akash deployment template to DefraDB
tools/cloud/akash
.Akash deployment URI: http://0i8se95qgletbeq16atqulhhc8.ingress.midwesternwireless.com/api/v0
Tasks
How has this been tested?
Manual deployment via Cloudmos.
Specify the platform(s) on which this was tested:
N/A