-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add unique secondary index #2131
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #2131 +/- ##
===========================================
+ Coverage 74.08% 74.20% +0.12%
===========================================
Files 248 248
Lines 24710 24845 +135
===========================================
+ Hits 18305 18434 +129
- Misses 5144 5145 +1
- Partials 1261 1266 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 7 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall it look good. I'm approving assuming we will resolve the 2 conversations before merging.
2305a99
to
07027af
Compare
## Relevant issue(s) Resolves sourcenetwork#298 ## Description Introduces unique secondary indexes.
## Relevant issue(s) Resolves sourcenetwork#298 ## Description Introduces unique secondary indexes.
Relevant issue(s)
Resolves #298
Description
Introduces unique secondary indexes.
Tasks
How has this been tested?
Unit and integration tests
Specify the platform(s) on which this was tested: