Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add unique secondary index #2131

Merged
merged 15 commits into from
Dec 19, 2023
Merged

feat: Add unique secondary index #2131

merged 15 commits into from
Dec 19, 2023

Conversation

islamaliev
Copy link
Contributor

Relevant issue(s)

Resolves #298

Description

Introduces unique secondary indexes.

Tasks

  • I made sure the code is well commented, particularly hard-to-understand areas.
  • I made sure the repository-held documentation is changed accordingly.
  • I made sure the pull request title adheres to the conventional commit style (the subset used in the project can be found in tools/configs/chglog/config.yml).
  • I made sure to discuss its limitations such as threats to validity, vulnerability to mistake and misuse, robustness to invalidation of assumptions, resource requirements, ...

How has this been tested?

Unit and integration tests

Specify the platform(s) on which this was tested:

  • MacOS

@islamaliev islamaliev added feature New feature or request area/query Related to the query component labels Dec 12, 2023
@islamaliev islamaliev added this to the DefraDB v0.9 milestone Dec 12, 2023
@islamaliev islamaliev self-assigned this Dec 12, 2023
Copy link

codecov bot commented Dec 12, 2023

Codecov Report

Attention: 38 lines in your changes are missing coverage. Please review.

Comparison is base (acc8e3e) 74.08% compared to head (0017a0e) 74.20%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2131      +/-   ##
===========================================
+ Coverage    74.08%   74.20%   +0.12%     
===========================================
  Files          248      248              
  Lines        24710    24845     +135     
===========================================
+ Hits         18305    18434     +129     
- Misses        5144     5145       +1     
- Partials      1261     1266       +5     
Flag Coverage Δ
all-tests 74.20% <82.96%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
cli/index_create.go 87.76% <100.00%> (+1.09%) ⬆️
client/index.go 100.00% <ø> (ø)
db/errors.go 72.44% <100.00%> (+0.70%) ⬆️
db/fetcher/indexer.go 80.00% <100.00%> (+1.11%) ⬆️
http/client_collection.go 35.62% <100.00%> (ø)
http/handler_collection.go 60.35% <100.00%> (+0.35%) ⬆️
request/graphql/schema/collection.go 91.69% <100.00%> (+0.31%) ⬆️
request/graphql/schema/types/types.go 100.00% <ø> (ø)
db/fetcher/indexer_iterators.go 82.06% <90.12%> (+1.53%) ⬆️
db/index.go 77.30% <70.00%> (-10.31%) ⬇️

... and 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acc8e3e...0017a0e. Read the comment docs.

db/collection_index.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@fredcarle fredcarle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it look good. I'm approving assuming we will resolve the 2 conversations before merging.

@islamaliev islamaliev force-pushed the feat/islam/unique-index branch from 2305a99 to 07027af Compare December 18, 2023 20:34
@islamaliev islamaliev merged commit 16c34b0 into develop Dec 19, 2023
32 checks passed
@islamaliev islamaliev deleted the feat/islam/unique-index branch December 19, 2023 11:26
shahzadlone pushed a commit to shahzadlone/defradb that referenced this pull request Jan 22, 2024
## Relevant issue(s)

Resolves sourcenetwork#298 

## Description

Introduces unique secondary indexes.
shahzadlone pushed a commit to shahzadlone/defradb that referenced this pull request Feb 23, 2024
## Relevant issue(s)

Resolves sourcenetwork#298 

## Description

Introduces unique secondary indexes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/query Related to the query component feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sec. Indexes: Implement unique indexes
2 participants