fix(i): Handle field in view query but not view SDL #2192
Conversation
AndrewSisley
added
bug
|
|
||
| func TestView_OneToManyWithRelationInQueryButNotInSDL(t *testing.T) { | ||
| test := testUtils.TestCase{ | ||
| Description: "One to many view", |
There was a problem hiding this comment.
todo: please the description more descriptive :)
There was a problem hiding this comment.
Lol - sorry 😁
- Sort out description(s?)
| UserView { | ||
| name | ||
| } | ||
| }`, |
There was a problem hiding this comment.
nitpick: indentation here (and in above query) is a bit off
There was a problem hiding this comment.
cheers, will fix
- Fix indentation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2192 +/- ##
===========================================
- Coverage 74.27% 74.26% -0.00%
===========================================
Files 256 256
Lines 25465 25477 +12
===========================================
+ Hits 18912 18920 +8
- Misses 5267 5271 +4
Partials 1286 1286
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 6 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
## Relevant issue(s) Resolves sourcenetwork#2183 sourcenetwork#2189 ## Description Handle field in view query but not view SDL. As such fields cannot be queried by the user anyway, we can safely ignore them (instead of panicing).
## Relevant issue(s) Resolves sourcenetwork#2183 sourcenetwork#2189 ## Description Handle field in view query but not view SDL. As such fields cannot be queried by the user anyway, we can safely ignore them (instead of panicing).
Relevant issue(s)
Resolves #2183 #2189
Description
Handle field in view query but not view SDL.
As such fields cannot be queried by the user anyway, we can safely ignore them (instead of panicing).