Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(i): Split build by OS for release workflow #2231

Conversation

fredcarle
Copy link
Collaborator

Relevant issue(s)

Resolves #2227

Description

This PR modifies the release workflow to split the build on the 3 different OS. This is needed now that we use wasmtime and CGO is needed for compilation.

@fredcarle fredcarle added the ci/build This is issue is about the build or CI system, and the administration of it. label Jan 18, 2024
@fredcarle fredcarle added this to the DefraDB v0.9 milestone Jan 18, 2024
@fredcarle fredcarle requested a review from a team January 18, 2024 17:09
@fredcarle fredcarle self-assigned this Jan 18, 2024
Copy link
Contributor

@AndrewSisley AndrewSisley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

Copy link

codecov bot commented Jan 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d1142a5) 74.25% compared to head (c9beb9f) 74.20%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2231      +/-   ##
===========================================
- Coverage    74.25%   74.20%   -0.04%     
===========================================
  Files          256      256              
  Lines        25508    25508              
===========================================
- Hits         18939    18928      -11     
- Misses        5280     5288       +8     
- Partials      1289     1292       +3     
Flag Coverage Δ
all-tests 74.20% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 10 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1142a5...c9beb9f. Read the comment docs.

@fredcarle fredcarle merged commit 58dc727 into sourcenetwork:develop Jan 18, 2024
31 of 32 checks passed
@fredcarle fredcarle deleted the fredcarle/chore/i2227-split-go-release branch January 18, 2024 17:55
shahzadlone pushed a commit to shahzadlone/defradb that referenced this pull request Jan 22, 2024
## Relevant issue(s)

Resolves sourcenetwork#2227 

## Description

This PR modifies the release workflow to split the build on the 3
different OS. This is needed now that we use wasmtime and CGO is needed
for compilation.
shahzadlone pushed a commit to shahzadlone/defradb that referenced this pull request Feb 23, 2024
## Relevant issue(s)

Resolves sourcenetwork#2227 

## Description

This PR modifies the release workflow to split the build on the 3
different OS. This is needed now that we use wasmtime and CGO is needed
for compilation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/build This is issue is about the build or CI system, and the administration of it.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Split build on go releaser
2 participants