feat: Add JSON scalar #2254
Merged
feat: Add JSON scalar #2254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredcarle
approved these changes
Jan 23, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #2254 +/- ##
===========================================
+ Coverage 74.07% 74.09% +0.02%
===========================================
Files 256 256
Lines 25731 25767 +36
===========================================
+ Hits 19058 19090 +32
- Misses 5356 5360 +4
Partials 1317 1317
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 7 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
shahzadlone
reviewed
Jan 24, 2024
Co-authored-by: Shahzad Lone <[email protected]>
shahzadlone
added a commit
to shahzadlone/defradb
that referenced
this pull request
Feb 23, 2024
## Relevant issue(s) Resolves sourcenetwork#2243 ## Description This PR adds a JSON scalar type to the schema system ## Tasks - [x] I made sure the code is well commented, particularly hard-to-understand areas. - [x] I made sure the repository-held documentation is changed accordingly. - [x] I made sure the pull request title adheres to the conventional commit style (the subset used in the project can be found in [tools/configs/chglog/config.yml](tools/configs/chglog/config.yml)). - [x] I made sure to discuss its limitations such as threats to validity, vulnerability to mistake and misuse, robustness to invalidation of assumptions, resource requirements, ... ## How has this been tested? make test Specify the platform(s) on which this was tested: - MacOS --------- Co-authored-by: Shahzad Lone <[email protected]>
|
bug bash issue #2370 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Resolves #2243
Description
This PR adds a JSON scalar type to the schema system
Tasks
How has this been tested?
make test
Specify the platform(s) on which this was tested: