Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(i): Document doc sync before schema update bug #2256

Merged

Conversation

AndrewSisley
Copy link
Contributor

Relevant issue(s)

Documents #2255

Description

Documents a bug (very likely cache related) when a doc syncs to a node on an older schema version before the schema is updated.

@AndrewSisley AndrewSisley added bug Something isn't working area/query Related to the query component area/schema Related to the schema system labels Jan 24, 2024
@AndrewSisley AndrewSisley requested a review from a team January 24, 2024 21:14
@AndrewSisley AndrewSisley self-assigned this Jan 24, 2024
@AndrewSisley AndrewSisley added this to the DefraDB v0.10 milestone Jan 24, 2024
Copy link

codecov bot commented Jan 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ba79b3b) 74.07% compared to head (037cd65) 74.11%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2256      +/-   ##
===========================================
+ Coverage    74.07%   74.11%   +0.04%     
===========================================
  Files          256      256              
  Lines        25767    25767              
===========================================
+ Hits         19086    19097      +11     
+ Misses        5362     5354       -8     
+ Partials      1319     1316       -3     
Flag Coverage Δ
all-tests 74.11% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 8 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba79b3b...037cd65. Read the comment docs.

Copy link
Member

@shahzadlone shahzadlone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AndrewSisley AndrewSisley merged commit 6f53af2 into sourcenetwork:develop Jan 24, 2024
31 of 32 checks passed
@AndrewSisley AndrewSisley deleted the 2255-doc-cache-sync-issue branch January 24, 2024 22:15
shahzadlone pushed a commit to shahzadlone/defradb that referenced this pull request Feb 23, 2024
## Relevant issue(s)

Documents sourcenetwork#2255

## Description

Documents a bug (very likely cache related) when a doc syncs to a node
on an older schema version before the schema is updated.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/query Related to the query component area/schema Related to the schema system bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants