feat: Replace FieldDescription.RelationType with IsPrimary #2288
Conversation
AndrewSisley
added
feature
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #2288 +/- ##
===========================================
- Coverage 74.24% 74.08% -0.16%
===========================================
Files 256 256
Lines 25789 25695 -94
===========================================
- Hits 19145 19034 -111
- Misses 5331 5347 +16
- Partials 1313 1314 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 8 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
If it was worth much, it would live somewhere else
Weird that they were created like this, as it wouldn't work anyway - likely copy-paste
AndrewSisley
force-pushed
the
2287-relation-type-cleanup
branch
from
d6e7dc1 to
5813c1b
Compare
AndrewSisley
changed the title
…work#2288) ## Relevant issue(s) Resolves sourcenetwork#2287 sourcenetwork#1772 ## Description Replaces `FieldDescription.RelationType` with an `IsPrimary` boolean. One notable effect of this that may not be easily visible in the code-diff is that the schema ID will not change depending on whether it is the primary side of a one-one or on the one side of a one-many - now the schema only cares about the shape of the data, not what is on the other side of the relationship.
|
found during bug bash, but most likely not directly related #2380 |
|
bug bash result: tested by creating different types and 1-to-1 and 1-no-many relationships and querying on them. Everything works |
Relevant issue(s)
Resolves #2287 #1772
Description
Replaces
FieldDescription.RelationTypewith anIsPrimaryboolean.One notable effect of this that may not be easily visible in the code-diff is that the schema ID will not change depending on whether it is the primary side of a one-one or on the one side of a one-many - now the schema only cares about the shape of the data, not what is on the other side of the relationship.
Commits should be clean, it might be easier reviewing them one by one.