Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix compound relational filters in aggregates #2297

Merged

Conversation

AndrewSisley
Copy link
Contributor

Relevant issue(s)

Resolves #1869

Description

Fixes compound relational filters in aggregates where their dependencies were not already part of the query.

@AndrewSisley AndrewSisley added bug Something isn't working area/query Related to the query component labels Feb 8, 2024
@AndrewSisley AndrewSisley added this to the DefraDB v0.10 milestone Feb 8, 2024
@AndrewSisley AndrewSisley requested a review from a team February 8, 2024 18:23
@AndrewSisley AndrewSisley self-assigned this Feb 8, 2024
Copy link
Collaborator

@fredcarle fredcarle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@shahzadlone shahzadlone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AndrewSisley AndrewSisley force-pushed the 1869-comp-rel-filter-agg branch from 541ad65 to a8b71b0 Compare February 8, 2024 23:55
@AndrewSisley AndrewSisley merged commit e28ea26 into sourcenetwork:develop Feb 9, 2024
27 of 28 checks passed
@AndrewSisley AndrewSisley deleted the 1869-comp-rel-filter-agg branch February 9, 2024 00:07
shahzadlone pushed a commit to shahzadlone/defradb that referenced this pull request Feb 23, 2024
## Relevant issue(s)

Resolves sourcenetwork#1869

## Description

Fixes compound relational filters in aggregates where their dependencies
were not already part of the query.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/query Related to the query component bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Panic using compound relational filter in top level aggregate
3 participants