Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Make config internal to CLI #2310

Merged
merged 13 commits into from
Feb 16, 2024

move rootdir to cli context

4ee8d50
Select commit
Loading
Failed to load commit list.
Merged

refactor: Make config internal to CLI #2310

move rootdir to cli context
4ee8d50
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 13, 2024 in 0s

74.25% (+0.27%) compared to 31297f8

View this Pull Request on Codecov

74.25% (+0.27%) compared to 31297f8

Details

Codecov Report

Attention: 73 lines in your changes are missing coverage. Please review.

Comparison is base (31297f8) 73.98% compared to head (4ee8d50) 74.25%.

❗ Current head 4ee8d50 differs from pull request most recent head 7b049a8. Consider uploading reports for the commit 7b049a8 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2310      +/-   ##
===========================================
+ Coverage    73.98%   74.25%   +0.27%     
===========================================
  Files          259      255       -4     
  Lines        25808    25240     -568     
===========================================
- Hits         19092    18741     -351     
+ Misses        5372     5204     -168     
+ Partials      1344     1295      -49     
Files Coverage Δ
cli/cli.go 100.00% <100.00%> (ø)
cli/tx_commit.go 68.42% <100.00%> (+3.72%) ⬆️
cli/tx_create.go 73.91% <100.00%> (ø)
cli/tx_discard.go 70.00% <100.00%> (+3.33%) ⬆️
cli/root.go 95.50% <94.59%> (+30.56%) ⬆️
cli/server_dump.go 18.52% <20.00%> (-0.71%) ⬇️
cli/client.go 55.00% <28.57%> (-9.71%) ⬇️
cli/collection.go 56.58% <14.29%> (-2.33%) ⬇️
cli/utils.go 53.68% <78.12%> (+11.79%) ⬆️
cli/start.go 7.87% <4.17%> (-27.77%) ⬇️
... and 1 more

... and 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31297f8...7b049a8. Read the comment docs.