Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools(i): Enable nilness linter #2383

Merged
merged 2 commits into from
Mar 6, 2024
Merged

tools(i): Enable nilness linter #2383

merged 2 commits into from
Mar 6, 2024

Conversation

nasdf
Copy link
Member

@nasdf nasdf commented Mar 6, 2024

Relevant issue(s)

Resolves #2382

Description

This PR enables the nilness linter and fixes a few issues caught by it.

Tasks

  • I made sure the code is well commented, particularly hard-to-understand areas.
  • I made sure the repository-held documentation is changed accordingly.
  • I made sure the pull request title adheres to the conventional commit style (the subset used in the project can be found in tools/configs/chglog/config.yml).
  • I made sure to discuss its limitations such as threats to validity, vulnerability to mistake and misuse, robustness to invalidation of assumptions, resource requirements, ...

How has this been tested?

make lint

Specify the platform(s) on which this was tested:

  • MacOS

@nasdf nasdf added this to the DefraDB v0.10 milestone Mar 6, 2024
@nasdf nasdf self-assigned this Mar 6, 2024
@nasdf nasdf requested a review from a team March 6, 2024 18:35
AndrewSisley
AndrewSisley approved these changes Mar 6, 2024
View reviewed changes
Copy link
Contributor

@AndrewSisley AndrewSisley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: That was quick - thanks Keenan 😁

fredcarle
fredcarle approved these changes Mar 6, 2024
View reviewed changes
Copy link
Collaborator

@fredcarle fredcarle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nasdf nasdf merged commit 76d8735 into sourcenetwork:develop Mar 6, 2024
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndrewSisley AndrewSisley AndrewSisley approved these changes

@fredcarle fredcarle fredcarle approved these changes

Assignees

@nasdf nasdf

Labels
config-change
Projects
None yet
Milestone
DefraDB v0.10
Development

Successfully merging this pull request may close these issues.

Enable nilness linter
3 participants
@nasdf @fredcarle @AndrewSisley