-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Add http/openapi documentation & ci workflow #2678
docs: Add http/openapi documentation & ci workflow #2678
Conversation
a37778e
to
20893fe
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2678 +/- ##
===========================================
+ Coverage 78.12% 78.15% +0.03%
===========================================
Files 303 303
Lines 23052 23052
===========================================
+ Hits 18009 18016 +7
+ Misses 3681 3675 -6
+ Partials 1362 1361 -1
Flags with carried forward coverage won't be shown. Click here to find out more. see 6 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
84f96b1
to
20893fe
Compare
|
||
.PHONY: docs\:cli | ||
docs\:cli: | ||
rm -f docs/website/references/cli/*.md | ||
go run cmd/genclidocs/main.go -o docs/website/references/cli | ||
|
||
.PHONY: docs\:http | ||
docs\:http: | ||
go run cmd/genopenapi/main.go | python -m json.tool > docs/website/references/http/openapi.json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: Why do we want to have the openAPI json output published in our docs? I'm asking because it's not really something to be read by humans.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can have it render a UI like this with some config options https://docs.source.network/sourcehub/api
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. Hopefully we can make the table easier to read because the one at the link is pretty terrible 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is one of my favourite API docs: https://docs.stripe.com/api
If we can eventually make it look like this but on top of it be able to execute the request to a configurable endpoint, that would be amazing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is one of my favourite API docs: docs.stripe.com/api If we can eventually make it look like this but on top of it be able to execute the request to a configurable endpoint, that would be amazing.
Nice the stripe docs look really nice. Whoever is responsible for website doc stuff can easily plug it in using the json
file this PR introduces
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
20893fe
to
2cc8e99
Compare
Relevant issue(s)
Related #510
Resolve #2677
Description
How has this been tested?
act
toolSpecify the platform(s) on which this was tested: