ci(i): Add workflow to detect out of date mocks #2679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shahzadlone
added
the
ci/build
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2679 +/- ##
===========================================
- Coverage 78.15% 78.13% -0.01%
===========================================
Files 303 303
Lines 23052 23052
===========================================
- Hits 18014 18011 -3
- Misses 3676 3679 +3
Partials 1362 1362
Flags with carried forward coverage won't be shown. Click here to find out more. see 6 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
AndrewSisley
approved these changes
Jun 4, 2024
| @@ -158,8 +158,8 @@ deps\:chglog: | |||
| deps\:modules: | |||
| go mod download | |||
|
|
|||
| .PHONY: deps\:mock | |||
| deps\:mock: | |||
| .PHONY: deps\:mocks | |||
There was a problem hiding this comment.
praise: Thanks - this one still trips me up 😁
shahzadlone
force-pushed
the
lone/ci/mocks-action
branch
2 times, most recently
from
e870009 to
a920c06
Compare
shahzadlone
force-pushed
the
lone/ci/mocks-action
branch
from
a920c06 to
231b5da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Resolves #1616
Description
How has this been tested?
acttool4b20f8f(#2679) and then seeing the action fail here: https://github.com/sourcenetwork/defradb/actions/runs/9361512099/job/25768647150?pr=2679Specify the platform(s) on which this was tested: