ci(i): Add action to ensure tidyness #2697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shahzadlone
force-pushed
the
lone/ci/ensure-go-mody-tidy-is-not-broken
branch
from
22fdde8 to
ab01887
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2697 +/- ##
===========================================
+ Coverage 77.97% 78.00% +0.03%
===========================================
Files 308 308
Lines 23134 23134
===========================================
+ Hits 18038 18045 +7
+ Misses 3714 3710 -4
+ Partials 1382 1379 -3
Flags with carried forward coverage won't be shown. Click here to find out more. see 7 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
shahzadlone
changed the title
make tidy is not brokenmake tidy
shahzadlone
force-pushed
the
lone/ci/ensure-go-mody-tidy-is-not-broken
branch
from
4d7b37d to
9bbe989
Compare
shahzadlone
added
the
ci/build
shahzadlone
changed the title
make tidy
shahzadlone
changed the title
make tidy
AndrewSisley
approved these changes
Jun 10, 2024
shahzadlone
changed the title
make tidy
ChrisBQu
pushed a commit
to ChrisBQu/defradb
that referenced
this pull request
Feb 21, 2025
## Relevant issue(s) Resolves #sourcenetwork#2695 ## Description ### Backstory - A commit (c42e7ee) broke mod tidy command recently - Which was fixed in the next commit in this PR: sourcenetwork#2548 - Some head scratching was done to find out that mod tidy needed a minimum version, hence the current pinned mod tidy There are 2 things being checked within the new added action: 1) That the backstory doesn't happen again (`make tidy` isn't broken). 2) `make tidy` is ran and up to date. NOTE: `(2)` above I am not sure if we want to keep, or not I would be okay with just `(1)`. However here are some reasons why you would want `(2)`: - always be in `tidy state` - one less command to do at release stage. ## How has this been tested? - Action that failed when `make tidy` was broken: https://github.com/sourcenetwork/defradb/actions/runs/9422665720/job/25959440810?pr=2697 - Action that failed when `make tidy` was not up to date (i.e. not tidy): https://github.com/sourcenetwork/defradb/actions/runs/9422726089/job/25959622978?pr=2697 Specify the platform(s) on which this was tested: - WSL2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Resolves ##2695
Description
Backstory
There are 2 things being checked within the new added action:
make tidyisn't broken).make tidyis ran and up to date.NOTE:
(2)above I am not sure if we want to keep, or not I would be okay with just(1). However here are some reasons why you would want(2):tidy stateHow has this been tested?
Action that failed when
make tidywas broken: https://github.com/sourcenetwork/defradb/actions/runs/9422665720/job/25959440810?pr=2697Action that failed when
make tidywas not up to date (i.e. not tidy):https://github.com/sourcenetwork/defradb/actions/runs/9422726089/job/25959622978?pr=2697
Specify the platform(s) on which this was tested: