fix: Incorporate schema root into docID #2701
Conversation
AndrewSisley
added
bug
| Request: fmt.Sprintf(`mutation { | ||
| delete_Book(docID: "%s") { | ||
| Request: `mutation { | ||
| delete_Book(docID: "bae-b5c56d8f-b2f5-57f9-b371-4e9e04903e91") { |
There was a problem hiding this comment.
question: Is it necessary to hardcode the docID here? You're doing the effort to switch to NewDocIndex in a lot of places. It seems like these would also be good candidates for that.
There was a problem hiding this comment.
We do not have support for DocIndex within the body of requests yet. This PR makes use of DocIndex where it (in it's current state) made the update easier, but the goal of this PR is not to propagate the usage of DocIndex, or to improve it.
This PR makes a needed production change to the DocID generation, and then updated the tests in the easiest way available.
AndrewSisley
force-pushed
the
2688-schema-doc-id
branch
from
b49e9dd to
bd1eee0
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2701 +/- ##
===========================================
+ Coverage 77.93% 78.01% +0.08%
===========================================
Files 308 308
Lines 23134 23135 +1
===========================================
+ Hits 18028 18048 +20
+ Misses 3721 3708 -13
+ Partials 1385 1379 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 12 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
AndrewSisley
force-pushed
the
2688-schema-doc-id
branch
from
ed1893c to
c8378a2
Compare
AndrewSisley
force-pushed
the
2688-schema-doc-id
branch
from
c8378a2 to
bb230fe
Compare
Relevant issue(s)
Resolves #2688
Description
Incorporates schema root into docID.
The production changes are all done in the first two commits, I broke out the test changes to a separate commit to avoid confusion. There are no significant test changes - is just really really painful updating this as besides the docIDs and cids, the order in which results were returned changed.