-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Resolve incorrect merge conflict #2723
fix: Resolve incorrect merge conflict #2723
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2723 +/- ##
===========================================
- Coverage 78.06% 77.95% -0.11%
===========================================
Files 310 310
Lines 23231 23236 +5
===========================================
- Hits 18133 18112 -21
- Misses 3717 3732 +15
- Partials 1381 1392 +11
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 9 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Co-authored-by: Shahzad Lone <[email protected]>
6022369
to
f0ab512
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks for fixing.
Relevant issue(s)
Resolves #2673
Description
This PR fixes the incorrect merge conflict in our memory store.
Tasks
How has this been tested?
make test
Specify the platform(s) on which this was tested: