-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(i): Update contributors #2743
docs(i): Update contributors #2743
Conversation
@@ -479,5 +479,6 @@ DefraDB's code is released under the [Business Source License (BSL)](licenses/BS | |||
- Orpheus Lummis ([@orpheuslummis](https://github.com/orpheuslummis)) | |||
- Fred Carle ([@fredcarle](https://github.com/fredcarle)) | |||
- Islam Aliev ([@islamaliev](https://github.com/islamaliev)) | |||
- Keenan Nemetz ([@nasdf](https://github.com/nasdf)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thought: Way overdue 😆 - however, do we really need this section? Contributors are listed in github, and over time manually growing this list will not scale well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could probably rename it to maintainers since there's a larger difference between contributors and active maintainers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be a good idea, although that would mean removing Orpheus from the list too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 😁
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2743 +/- ##
===========================================
- Coverage 78.15% 78.14% -0.01%
===========================================
Files 310 310
Lines 23069 23069
===========================================
- Hits 18029 18026 -3
- Misses 3667 3670 +3
Partials 1373 1373
Flags with carried forward coverage won't be shown. Click here to find out more. see 10 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
No description provided.