Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(i): Update contributors #2743

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

nasdf
Copy link
Member

@nasdf nasdf commented Jun 20, 2024

No description provided.

@nasdf nasdf self-assigned this Jun 20, 2024
@nasdf nasdf added the documentation Improvements or additions to documentation label Jun 20, 2024
@@ -479,5 +479,6 @@ DefraDB's code is released under the [Business Source License (BSL)](licenses/BS
- Orpheus Lummis ([@orpheuslummis](https://github.com/orpheuslummis))
- Fred Carle ([@fredcarle](https://github.com/fredcarle))
- Islam Aliev ([@islamaliev](https://github.com/islamaliev))
- Keenan Nemetz ([@nasdf](https://github.com/nasdf))
Copy link
Contributor

@AndrewSisley AndrewSisley Jun 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thought: Way overdue 😆 - however, do we really need this section? Contributors are listed in github, and over time manually growing this list will not scale well.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could probably rename it to maintainers since there's a larger difference between contributors and active maintainers

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be a good idea, although that would mean removing Orpheus from the list too

Copy link
Contributor

@AndrewSisley AndrewSisley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😁

Copy link

codecov bot commented Jun 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.14%. Comparing base (3856b80) to head (9f662a0).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2743      +/-   ##
===========================================
- Coverage    78.15%   78.14%   -0.01%     
===========================================
  Files          310      310              
  Lines        23069    23069              
===========================================
- Hits         18029    18026       -3     
- Misses        3667     3670       +3     
  Partials      1373     1373              
Flag Coverage Δ
all-tests 78.14% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 10 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3856b80...9f662a0. Read the comment docs.

@nasdf nasdf merged commit c1b612e into sourcenetwork:develop Jun 20, 2024
38 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants