Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools(i): Make one command do all the steps #2772

Merged

Conversation

shahzadlone
Copy link
Member

@shahzadlone shahzadlone commented Jun 25, 2024

Relevant issue(s)

Resolves #2771

Description

Runs all the developer make commands in one command.

How has this been tested?

locally

Specify the platform(s) on which this was tested:

  • WSL2

@shahzadlone shahzadlone added the code quality Related to improving code quality label Jun 25, 2024
@shahzadlone shahzadlone requested a review from a team June 25, 2024 16:56
@shahzadlone shahzadlone self-assigned this Jun 25, 2024
@shahzadlone shahzadlone force-pushed the ci/lone/fix-all-ci-gen-steps branch from 438ea1d to 22affa2 Compare June 25, 2024 16:56
@shahzadlone shahzadlone changed the title tools(i): Make one command to do all the steps tools(i): Make one command do all the steps Jun 25, 2024
Copy link
Contributor

@AndrewSisley AndrewSisley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.24%. Comparing base (f627448) to head (22affa2).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2772      +/-   ##
===========================================
+ Coverage    78.09%   78.24%   +0.15%     
===========================================
  Files          313      313              
  Lines        23111    23111              
===========================================
+ Hits         18047    18081      +34     
+ Misses        3684     3661      -23     
+ Partials      1380     1369      -11     
Flag Coverage Δ
all-tests 78.24% <ø> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 13 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f627448...22affa2. Read the comment docs.

@shahzadlone shahzadlone merged commit a9f8dee into sourcenetwork:develop Jun 25, 2024
40 of 41 checks passed
@shahzadlone shahzadlone deleted the ci/lone/fix-all-ci-gen-steps branch June 25, 2024 17:20
ChrisBQu pushed a commit to ChrisBQu/defradb that referenced this pull request Feb 21, 2025
## Relevant issue(s)
Resolves sourcenetwork#2771

## Description
Runs all the developer make commands in one command.


## How has this been tested?
locally

Specify the platform(s) on which this was tested:
- WSL2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality Related to improving code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce one make fix command that does all the fixing dev related checks
2 participants