Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Change new identity keys to hex format #2773

Conversation

shahzadlone
Copy link
Member

@shahzadlone shahzadlone commented Jun 25, 2024

Relevant issue(s)

Resolves #2770

Description

  • Return the priv/pub keys in hex

Specify the platform(s) on which this was tested:

  • WSL2

@shahzadlone shahzadlone added the refactor This issue specific to or requires *notable* refactoring of existing codebases and components label Jun 25, 2024
@shahzadlone shahzadlone added this to the DefraDB v0.12 milestone Jun 25, 2024
@shahzadlone shahzadlone requested a review from a team June 25, 2024 18:02
@shahzadlone shahzadlone self-assigned this Jun 25, 2024
Copy link
Contributor

@AndrewSisley AndrewSisley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Shahzad (I'm assuming you update the CLI docs before merge :))

@shahzadlone
Copy link
Member Author

LGTM, thanks Shahzad (I'm assuming you update the CLI docs before merge :))

Yup it's done.

Copy link

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.17%. Comparing base (a9f8dee) to head (cfaf40e).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2773      +/-   ##
===========================================
+ Coverage    78.16%   78.17%   +0.01%     
===========================================
  Files          313      313              
  Lines        23111    23116       +5     
===========================================
+ Hits         18063    18069       +6     
+ Misses        3673     3671       -2     
- Partials      1375     1376       +1     
Flag Coverage Δ
all-tests 78.17% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
acp/identity/generate.go 60.00% <100.00%> (ø)
cli/identity_new.go 89.47% <100.00%> (+3.76%) ⬆️

... and 12 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9f8dee...cfaf40e. Read the comment docs.

@shahzadlone shahzadlone merged commit 0a0657f into sourcenetwork:develop Jun 25, 2024
39 of 40 checks passed
@shahzadlone shahzadlone deleted the lone/fix/make-priv-key-hex-encoded branch June 25, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor This issue specific to or requires *notable* refactoring of existing codebases and components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

defradb identity new returns keys in encoding not supported by defra calls
2 participants