-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Doc field encryption #2817
feat: Doc field encryption #2817
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2817 +/- ##
===========================================
+ Coverage 79.14% 79.17% +0.03%
===========================================
Files 318 319 +1
Lines 24162 24256 +94
===========================================
+ Hits 19122 19203 +81
- Misses 3660 3667 +7
- Partials 1380 1386 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 11 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Likely also want to add the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Islam, thanks :) Just got a couple of todo's for your RE GQL and testing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks Islam :)
161bf15
to
0b8b878
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Great work!
One thought I had after reviewing: it might be beneficial to merge all of the db context related stuff into a single package at some point in the future.
I like that thought :) |
0b8b878
to
7398c12
Compare
I'm not a big fan to be honest. I'd much prefer to split and group packages by their domain, not based on their functional types. Just because they have something to do with |
I understand what you mean, but for me (thinking as a user) I see them all in the 'Defra' domain, just like we lump config, and the |
Relevant issue(s)
Resolves #2809 #2812
Description
Adds field-level encryption which allows separate fields
to be encryption with a dedicated symmectic key.