Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Secure document encryption key exchange #2891

Merged

PR fixup

a492a1d
Select commit
Loading
Failed to load commit list.
Merged

feat: Secure document encryption key exchange #2891

PR fixup
a492a1d
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 23, 2024 in 1s

79.41% (-0.02%) compared to d872a0c

View this Pull Request on Codecov

79.41% (-0.02%) compared to d872a0c

Details

Codecov Report

Attention: Patch coverage is 78.55191% with 157 lines in your changes missing coverage. Please review.

Project coverage is 79.41%. Comparing base (d872a0c) to head (a492a1d).

Files with missing lines Patch % Lines
internal/kms/pubsub.go 66.67% 33 Missing and 20 partials ⚠️
internal/db/merge.go 82.40% 11 Missing and 11 partials ⚠️
crypto/ecies.go 85.57% 7 Missing and 7 partials ⚠️
internal/merkle/clock/clock.go 77.42% 8 Missing and 6 partials ⚠️
crypto/errors.go 28.57% 10 Missing ⚠️
internal/kms/enc_store.go 66.67% 4 Missing and 4 partials ⚠️
crypto/aes.go 81.25% 3 Missing and 3 partials ⚠️
internal/core/block/block.go 90.00% 3 Missing and 3 partials ⚠️
internal/encryption/encryptor.go 90.70% 3 Missing and 1 partial ⚠️
net/errors.go 0.00% 4 Missing ⚠️
... and 8 more
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2891      +/-   ##
===========================================
- Coverage    79.42%   79.41%   -0.02%     
===========================================
  Files          336      342       +6     
  Lines        26074    26529     +455     
===========================================
+ Hits         20709    21066     +357     
- Misses        3889     3945      +56     
- Partials      1476     1518      +42     
Files with missing lines Coverage Δ
cli/collection_create.go 76.00% <100.00%> (+1.64%) ⬆️
client/db.go 91.30% <ø> (ø)
datastore/multi.go 92.00% <100.00%> (ø)
internal/core/block/errors.go 52.38% <ø> (+23.81%) ⬆️
internal/core/crdt/composite.go 75.76% <100.00%> (ø)
internal/core/key.go 82.60% <100.00%> (-0.02%) ⬇️
internal/db/base/collection_keys.go 86.96% <100.00%> (ø)
internal/db/collection.go 73.28% <100.00%> (ø)
internal/db/collection_delete.go 39.53% <100.00%> (ø)
internal/db/config.go 100.00% <100.00%> (ø)
... and 33 more

... and 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d872a0c...a492a1d. Read the comment docs.