Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Ability to relate private documents to actors #2907

Merged
merged 12 commits into from
Oct 2, 2024

PR(DOCS): Update Documentation + `make docs`

5c05eeb
Select commit
Loading
Failed to load commit list.
Merged

feat: Ability to relate private documents to actors #2907

PR(DOCS): Update Documentation + `make docs`
5c05eeb
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 2, 2024 in 0s

79.70% (+0.28%) compared to 3101c61

View this Pull Request on Codecov

79.70% (+0.28%) compared to 3101c61

Details

Codecov Report

Attention: Patch coverage is 93.13725% with 21 lines in your changes missing coverage. Please review.

Project coverage is 79.70%. Comparing base (3101c61) to head (5c05eeb).

Files with missing lines Patch % Lines
acp/acp_source_hub.go 74.19% 4 Missing and 4 partials ⚠️
http/handler_acp.go 82.35% 4 Missing and 2 partials ⚠️
http/client_acp.go 83.33% 2 Missing and 2 partials ⚠️
internal/db/db.go 86.96% 2 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2907      +/-   ##
===========================================
+ Coverage    79.42%   79.70%   +0.28%     
===========================================
  Files          346      348       +2     
  Lines        26715    27014     +299     
===========================================
+ Hits         21217    21530     +313     
+ Misses        3964     3957       -7     
+ Partials      1534     1527       -7     
Files with missing lines Coverage Δ
acp/acp_local.go 97.56% <100.00%> (+0.29%) ⬆️
acp/errors.go 88.07% <100.00%> (+3.02%) ⬆️
acp/source_hub_client.go 91.15% <100.00%> (+2.95%) ⬆️
cli/acp_relationship.go 100.00% <100.00%> (ø)
cli/acp_relationship_add.go 100.00% <100.00%> (ø)
cli/cli.go 100.00% <100.00%> (ø)
client/db.go 91.30% <ø> (ø)
client/errors.go 59.72% <ø> (ø)
internal/db/permission/check.go 85.19% <100.00%> (ø)
internal/db/permission/permission.go 100.00% <100.00%> (ø)
... and 5 more

... and 21 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3101c61...5c05eeb. Read the comment docs.