Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump to GoLang v1.22 #2911

Closed

Conversation

shahzadlone
Copy link
Member

@shahzadlone shahzadlone commented Aug 14, 2024

NOTE: This PR should likely be merged in v0.14 Defra Release not the current one.

Relevant issue(s)

Resolves #2431

Description

  • This is a routine version bump of GoLang, the previous bump was done in (chore: Bump to GoLang v1.21 #2195)
  • Also updates the golang version for AWS AMI generation.
  • Update all loop todos for 1.22 by removing the copy variables.

@shahzadlone shahzadlone added the bump Bumped version for something label Aug 14, 2024
@shahzadlone shahzadlone self-assigned this Aug 14, 2024
Copy link

codecov bot commented Aug 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.47%. Comparing base (defb37a) to head (c746c7e).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2911      +/-   ##
===========================================
- Coverage    79.51%   79.47%   -0.04%     
===========================================
  Files          325      325              
  Lines        24778    24774       -4     
===========================================
- Hits         19700    19688      -12     
- Misses        3669     3675       +6     
- Partials      1409     1411       +2     
Flag Coverage Δ
all-tests 79.47% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
internal/lens/history.go 100.00% <100.00%> (ø)
internal/planner/commit.go 83.24% <100.00%> (-0.09%) ⬇️
internal/request/graphql/schema/generate.go 87.92% <100.00%> (-0.03%) ⬇️

... and 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update defb37a...c746c7e. Read the comment docs.

@shahzadlone
Copy link
Member Author

Close this in favor of: #2913

Because we need branch flow for the AMI action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump Bumped version for something
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Go version to 1.22
1 participant