Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Ability to unrelate private documents from actors #3099

Merged
merged 12 commits into from
Oct 4, 2024

PR(ADHERE-REVIEW): Check `require.Equal` after the `assertExpectedErr…

9d7e222
Select commit
Loading
Failed to load commit list.
Merged

feat: Ability to unrelate private documents from actors #3099

PR(ADHERE-REVIEW): Check `require.Equal` after the `assertExpectedErr…
9d7e222
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 4, 2024 in 0s

No report found to compare against

View this Pull Request on Codecov

No report found to compare against

Details

Codecov Report

Attention: Patch coverage is 93.42105% with 20 lines in your changes missing coverage. Please review.

Please upload report for BASE (develop@bc93bff). Learn more about missing BASE report.

Files with missing lines Patch % Lines
acp/acp_source_hub.go 74.19% 4 Missing and 4 partials ⚠️
http/handler_acp.go 89.47% 4 Missing and 2 partials ⚠️
http/client_acp.go 83.33% 2 Missing and 2 partials ⚠️
internal/db/db.go 90.91% 1 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #3099   +/-   ##
==========================================
  Coverage           ?   80.08%           
==========================================
  Files              ?      353           
  Lines              ?    28068           
  Branches           ?        0           
==========================================
  Hits               ?    22478           
  Misses             ?     4006           
  Partials           ?     1584
Files with missing lines Coverage Δ
acp/acp_local.go 97.78% <100.00%> (ø)
acp/errors.go 90.08% <100.00%> (ø)
acp/source_hub_client.go 92.92% <100.00%> (ø)
cli/acp_relationship_add.go 100.00% <100.00%> (ø)
cli/acp_relationship_delete.go 100.00% <100.00%> (ø)
cli/cli.go 100.00% <100.00%> (ø)
client/db.go 91.30% <ø> (ø)
http/openapi.go 98.10% <ø> (ø)
internal/db/db.go 66.46% <90.91%> (ø)
http/client_acp.go 83.87% <83.33%> (ø)
... and 2 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc93bff...9d7e222. Read the comment docs.

View more details on Codecov