-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Aggregate order alias targeting #3293
feat: Aggregate order alias targeting #3293
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3293 +/- ##
===========================================
+ Coverage 78.00% 78.10% +0.10%
===========================================
Files 382 382
Lines 35364 35364
===========================================
+ Hits 27583 27618 +35
+ Misses 6138 6114 -24
+ Partials 1643 1632 -11
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 10 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
"Author": []map[string]any{ | ||
{ | ||
"name": "John Grisham", | ||
"totalRating": 13.600000000000001, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thought: Yay for float precision.... lol
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for adding the tests ensuring this is implemented.
Bug bash result: ran different requests similar to integration tests. Everything works. |
Relevant issue(s)
Resolves #3239
Resolves #2820
Description
This PR enables ordering by aggregated fields by using an alias to target them. This was mostly implemented in a previous PR, so the changes here are tests to verify that it works.
Tasks
How has this been tested?
Added integration tests.
Specify the platform(s) on which this was tested: