Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add 'keyring list' command to CLI #3331

Merged
merged 30 commits into from
Jan 1, 2025

Error output to systemKeyring.List and unit test

c16d843
Select commit
Loading
Failed to load commit list.
Merged

feat: Add 'keyring list' command to CLI #3331

Error output to systemKeyring.List and unit test
c16d843
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 18, 2024 in 0s

77.96% (-0.09%) compared to 363fe9c

View this Pull Request on Codecov

77.96% (-0.09%) compared to 363fe9c

Details

Codecov Report

Attention: Patch coverage is 72.91667% with 13 lines in your changes missing coverage. Please review.

Project coverage is 77.96%. Comparing base (363fe9c) to head (c16d843).

Files with missing lines Patch % Lines
cli/keyring_list.go 67.74% 7 Missing and 3 partials ⚠️
keyring/file.go 72.73% 2 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3331      +/-   ##
===========================================
- Coverage    78.05%   77.96%   -0.09%     
===========================================
  Files          388      389       +1     
  Lines        35398    35446      +48     
===========================================
+ Hits         27629    27634       +5     
- Misses        6133     6161      +28     
- Partials      1636     1651      +15     
Files with missing lines Coverage Δ
cli/cli.go 100.00% <100.00%> (ø)
keyring/system.go 36.00% <100.00%> (+36.00%) ⬆️
keyring/file.go 67.57% <72.73%> (+2.18%) ⬆️
cli/keyring_list.go 67.74% <67.74%> (ø)

... and 19 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 363fe9c...c16d843. Read the comment docs.