Remove deprecation warning when depend of EOL cookbook #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damacus
approved these changes
Jan 7, 2023
damacus
added
the
Release: Minor
|
Released as: 6.3.0 |
tas50
reviewed
Jan 7, 2023
| @@ -10,5 +10,5 @@ | |||
|
|
|||
| supports 'windows' | |||
|
|
|||
| depends 'windows', '>= 3.0' | |||
| depends 'windows', '>= 3.0' unless Chef::VERSION.to_f >= 14 | |||
There was a problem hiding this comment.
This doesn't actually work. It gets parsed at upload based on the version on workstation
There was a problem hiding this comment.
I'll make a PR which bumps the required version of Chef and remove this dependency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove deprecation warning when depends of EOL cookbook (windows)
Issues Resolved
Check List
## Unreleased