Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove deprecation warning #89

Merged
merged 1 commit into from
Jun 9, 2016

Conversation

mhorbul
Copy link
Contributor

@mhorbul mhorbul commented Jun 3, 2016

Description

This PR removes deprecation warning introduced by this change in chef repo
chef/chef@97aaf5b

Issues Resolved

  • fix deprecation warning

Check List

@mhorbul mhorbul force-pushed the mhorbul/deprication-warnings branch from 48733eb to c0e1f8b Compare June 3, 2016 05:19
@vinyar
Copy link

vinyar commented Jun 9, 2016

ooo... i just filed a bug on this, gonna give it a spin right now

@vinyar
Copy link

vinyar commented Jun 9, 2016

so, i just gave it a spin (and learned that it's very difficult to find the origin of the PR (or that i suck at github.com))
Berksfile:

source 'https://supermarket.chef.io'
cookbook 'powershell', git: 'https://github.com/eligible/powershell.git', ref: 'c0e1f8bbfc7adc7464e7cc321572dbb84fdb1341'
metadata

Warning (assuming that's the one you fixed) is still there:

       Deprecated features used!
         Using an LWRP provider by its name (WindowsFeatureDism) directly is no longer supported in Chef 12 and will be removed.  Use Chef::ProviderResolver.new(node, resource, action) instead. at 1 location:
           - C:\Users\vagrant\AppData\Local\Temp\kitchen\cookbooks\windows\resources\feature.rb:32:in `initialize'

       Chef Client finished, 0/1 resources updated in 03 seconds
       Finished converging <certification-wind2012-r2> (0m9.37s).
-----> Kitchen is finished. (0m11.90s)

@mhorbul
Copy link
Contributor Author

mhorbul commented Jun 9, 2016

The Warning which is fixed by this PR is the following

  The on_platforms option to node_map has been deprecated at 1 location:
    - /var/chef/cache/cookbooks/compat_resource/files/lib/chef_compat/monkeypatches/chef.rb:20:in `log_deprecation'

@smurawski
Copy link
Contributor

closes #90

@smurawski smurawski merged commit f39956b into sous-chefs:master Jun 9, 2016
@mhorbul mhorbul deleted the mhorbul/deprication-warnings branch June 9, 2016 21:42
@vinyar
Copy link

vinyar commented Jun 10, 2016

i didnt even realize the error was from windows cookbook
@mhorbul 2am comments on github will do that 👍 thanks for the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants