Add hideOnBlur config option (#20)

* Add hideOnBlur config option * Remove unused import * Add electron as peerDependency
soutar · Jun 13, 2017 · c49ef0a · c49ef0a
1 parent 6772ab8
commit c49ef0a
Show file tree

Hide file tree

Showing 3 changed files with 388 additions and 28 deletions.
diff --git a/modules/setup.js b/modules/setup.js
@@ -1,9 +1,9 @@
 const registerShortcut = require('hyperterm-register-shortcut');
-const toggleWindowVisibility = require('./windows').toggleWindowVisibility;
-const showWindows = require('./windows').showWindows;
+const windows = require('./windows');
 
 const DEFAULTS = {
-  hideDock: false
+  hideDock: false,
+  hideOnBlur: true
 }
 
 module.exports = function setup (app, windowSet) {
@@ -13,9 +13,21 @@ module.exports = function setup (app, windowSet) {
     app.dock.hide();
   }
 
-  registerShortcut('summon', toggleWindowVisibility)(app, windowSet);
+  registerShortcut('summon', windows.toggleWindowVisibility)(app, windowSet);
 
   app.on('activate', () => {
-    showWindows([...windowSet], app);
+    windows.showWindows([...windowSet], app);
   });
+
+  if (config.hideOnBlur) {
+    app.on('browser-window-blur', () => {
+      const focusedWindows = [...windowSet].filter(window => window.isFocused());
+
+      if (focusedWindows.length > 0) {
+        return false;
+      }
+
+      windows.hideWindows([...windowSet], app);
+    });
+  }
 }
diff --git a/modules/setup.test.js b/modules/setup.test.js
@@ -1,18 +1,28 @@
 const setup = require('./setup');
 
+jest.mock('./windows')
 jest.mock('hyperterm-register-shortcut');
 
-let app = {
-  config: {
-    getConfig: jest.fn(() => ({}))
-  },
-  dock: {
-    hide: jest.fn()
-  },
-  on: jest.fn()
-};
+let app;
 
 describe('setup', () => {
+  beforeAll(() => {
+    app = {
+      config: {
+        getConfig: jest.fn(() => ({}))
+      },
+      dock: {
+        hide: jest.fn()
+      },
+      on: jest.fn()
+    }
+  });
+
+  afterEach(() => {
+    app.dock.hide.mockClear()
+    app.on.mockClear()
+  })
+
   describe('with default config', () => {
     beforeEach(() => {
       setup(app);
@@ -21,6 +31,10 @@ describe('setup', () => {
     it('does not hide the dock', () => {
       expect(app.dock.hide).not.toHaveBeenCalled();
     });
+
+    it('handles blur events', () => {
+      expect(app.on).toHaveBeenCalledWith('browser-window-blur', expect.any(Function));
+    });
   });
 
   describe('with hideDock config enabled', () => {
@@ -29,12 +43,27 @@ describe('setup', () => {
         summon: {
           hideDock: true
         }
-      })
+      });
       setup(app);
     });
 
     it('hides the dock', () => {
       expect(app.dock.hide).toHaveBeenCalled();
     });
   });
-})
+
+  describe('with hideOnBlur config disabled', () => {
+    beforeEach(() => {
+      app.config.getConfig.mockReturnValueOnce({
+        summon: {
+          hideOnBlur: false
+        }
+      });
+      setup(app);
+    });
+
+    it('does not handle blur events', () => {
+      expect(app.on).not.toHaveBeenCalledWith('browser-window-blur', expect.any(Function));
+    });
+  });
+});