Prove that ember-scoped-css doesn't change class names as you move classic -> embroider -> etc #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wip fix format Re-roll lockfile
NullVoxPopuli
force-pushed
the
prove-that-the-migration-path-keeps-all-the-same-classes
branch
from
e3d14c2 to
69a8cb1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternatively, we can force the assumption that the generated class name is private API and folks shouldn't be using it.
This would mean that the tests in these apps would need to not ever assert against the raw string.
However the work to support name aliasing is still required for maintenance reasons to have all test-apps have the same base scenarios to test.