Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed empty text between html elements #10

Merged
merged 8 commits into from
Nov 8, 2021
Merged

Fixed empty text between html elements #10

merged 8 commits into from
Nov 8, 2021

Conversation

candunaj
Copy link
Contributor

@candunaj candunaj commented Nov 3, 2021

Fix empty spaces between HTML elements.
I have added unit tests based on currently supported functionality.
Exclude auditboard-icon from translations.

@candunaj candunaj requested a review from mansona November 3, 2021 15:16
@mansona mansona changed the title Empty text Fixed empty text between html elements Nov 5, 2021
@candunaj candunaj changed the title Fixed empty text between html elements [WIP] Fixed empty text between html elements Nov 5, 2021
@candunaj candunaj force-pushed the empty-text branch 2 times, most recently from 9155848 to 72021db Compare November 5, 2021 11:36
Copy link
Contributor

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this is a really great PR 🎉 the test cases are very clear and the functionality is pretty amazing! great work

I have one comment and one thing that should probably be changed before we merge tho

lib/helpers.js Outdated Show resolved Hide resolved
lib/helpers.js Outdated Show resolved Hide resolved
Copy link
Contributor

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic work 🎉

@mansona mansona changed the title [WIP] Fixed empty text between html elements Fixed empty text between html elements Nov 8, 2021
@mansona mansona merged commit c37f7e5 into main Nov 8, 2021
@mansona mansona deleted the empty-text branch November 8, 2021 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants