Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Implement Pattern Defeating Quick Sort algorithm #180

Merged
merged 2 commits into from
May 24, 2024
Merged

Implement Pattern Defeating Quick Sort algorithm #180

merged 2 commits into from
May 24, 2024

Conversation

sozelfist
Copy link
Owner

No description provided.

@sozelfist sozelfist added the features Implement a new feature, algorithms or data structures label May 23, 2024
@sozelfist sozelfist self-assigned this May 23, 2024
@sozelfist sozelfist changed the title Implement Partition Defeating Quick Sort algorithm Implement Pattern Defeating Quick Sort algorithm May 23, 2024
sozelfist
sozelfist commented May 24, 2024
View reviewed changes
Copy link
Owner Author

@sozelfist sozelfist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will add generic type T to the current implementation to make the code sort on any type.

sozelfist
sozelfist commented May 24, 2024
View reviewed changes
Copy link
Owner Author

@sozelfist sozelfist left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docstring needs updating, function arguments must have type hints, and tests for list of strings need to be added.

algorithms/sorting/pdqsort.py Outdated Show resolved Hide resolved
algorithms/sorting/pdqsort.py Outdated Show resolved Hide resolved
algorithms/sorting/pdqsort.py Outdated Show resolved Hide resolved
algorithms/sorting/pdqsort.py Outdated Show resolved Hide resolved
algorithms/sorting/pdqsort.py Outdated Show resolved Hide resolved
algorithms/sorting/pdqsort.py Show resolved Hide resolved
@sozelfist
ref: refactor implementation
b63ab9a 
- Add type hints and generic type T to the implementation
- Add tests for list of strings
- Update docstrings
@sozelfist
Copy link
Owner Author

It's look good now, ready to be merged. 🚀

@sozelfist sozelfist merged commit 0b8a248 into master May 24, 2024
6 checks passed
@sozelfist sozelfist deleted the feat/sorting/pdqsort branch May 24, 2024 01:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@sozelfist sozelfist

Labels
features Implement a new feature, algorithms or data structures
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sozelfist