Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On after signup edit page: form validation not working properly #175

Open
1000miles opened this issue Apr 4, 2016 · 4 comments · May be fixed by #359
Open

On after signup edit page: form validation not working properly #175

1000miles opened this issue Apr 4, 2016 · 4 comments · May be fixed by #359
Assignees
@holgerd
Labels
bug

Comments

@1000miles
Copy link
Collaborator

1000miles commented Apr 4, 2016 •
edited by holgerd
Loading

Case:

  • I have registered as a new user at openstreetmap.org
  • I am logged in
  • I am on after signup edit page (/profile/after_signup_edit)
  • I leave the email input field empty (even though it is marked as required) or I type in a non-valid email address with dfdgfdgdg
  • I click on Fertigstellen button

=> I should get an error message which tells me to provide an email address first in order to complete the signup process, instead I get the success message: Du bekommst in wenigen Minuten eine E-Mail mit einem Link, um deine E-Mail-Adresse zu bestätigen.

In the browser inspector I can find this:
<div id="user_email_input" class="email input required stringish form-group">

@lennerd It seems the form validation doesn't work properly?

after_signup_edit_page_message
@1000miles 1000miles added the bug label Apr 4, 2016
@lennerd
Copy link
Collaborator

lennerd commented Apr 4, 2016

Yeah, that seems to be a bug. I will take a look at this as soon as #105 is deployed.

@lennerd lennerd self-assigned this Apr 4, 2016
@1000miles
Copy link
Collaborator Author

👍 Thank you for looking into it.

@lennerd lennerd removed their assignment Apr 4, 2016
@1000miles 1000miles mentioned this issue Apr 8, 2016
Open
3 tasks
@holgerd holgerd added the next label Aug 1, 2016
@lennerd lennerd added in progress and removed next labels Aug 1, 2016
@lennerd
Copy link
Collaborator

lennerd commented Aug 1, 2016

Do you created a new account or did you login with an existing one?

@lennerd lennerd linked a pull request Aug 15, 2016 that will close this issue
Open
1 task
@holgerd holgerd self-assigned this Oct 25, 2016
@holgerd holgerd added review and removed review labels Oct 25, 2016
@holgerd
Copy link
Member

holgerd commented Oct 25, 2016

on hold, waiting for PR #359 to review.

@holgerd holgerd added on hold and removed review labels Oct 25, 2016
@1000miles 1000miles added this to the HolgerIsWorkingOnThis milestone Nov 1, 2016
@1000miles 1000miles removed the on hold label Nov 1, 2016
@ghost ghost removed this from the Start February 7 milestone Feb 14, 2017
@ghost ghost modified the milestones: Start February 14, Start Feb 21 Feb 22, 2017
@holgerd holgerd modified the milestone: Start Feb 21 May 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@holgerd holgerd

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix/login signup sozialhelden/wheelmap-classic
3 participants
@holgerd @lennerd @1000miles