Fix/login signup

[lennerd]

This PR tries to fix #175, #179 and #181.

What did change?

• The user email address is mandatory now. If a user is logged in for the first time or did not set an email address yet, we always show them after_signup_update page to add a email address.
  This part is really critical I think. We need to be sure to force user to have a email address. There is a quite big opportunity users get angry or frustrated because they are forced to give data to us.
  We also need to check if this has any implications for the apps on the mobile devices.
• The user password was only needed so users were able to login via their mobile devices. As we refactored this process completely via an integrated WebView, I removed the password field completely.
• The after_signup_update view cannot be skipped anymore.
• I remove some of the duplicate flash messages and JavaScript alerts, which were shown when the user clicked on the submit button or reached the front page.

What needs to be done?

• Fix tests.

Note:

• I thought a while about making after_signup_update "beautiful again" and I decided to don't touch it. The problem is that we do not have any kind of Style Guide which can be applied here or was applied to every page on the platform. Adding once again another form style will lead to more and more CSS lines and a quite bloated Stylesheet.

[lennerd]

I realized, that it was a total stupid idea to remove password completely as we have admin users who need a password to login. I will revert that part of the PR.

[holgerd]

@lennerd I tried to test this on staging but get errors:

• Using Firefox Mac I click "login" and "login with OSM" and login to OSM using [email protected]. I get back to the add email form on wheelmap and type in [email protected]. I get a notification that I'll get a confirmation email and click "OK"
• I expect the then come to wheelmap homepage and be logged in
• Instead, I see a "502 bad gateway" error from cloudflare (see screenshot). When I reload the page https://staging.wheelmap.org/profile/after_signup_update (which is in the browser bar) I get "The page you were looking for doesn't exist."

[lennerd]

@holgerd This not on deployed on Staging so maybe you discovered another error.

[holgerd]

ok, let me know when I can test something on staging.

Lennart Hildebrandt [email protected] schrieb am Di., 16. Aug.
2016 um 11:42 Uhr:

This not on deployed on Staging so maybe you discovered another error.

—
You are receiving this because you commented.

Reply to this email directly, view it on GitHub
#359 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AANVilIZrkmd5lcGLhaHea8du6aOCILgks5qgYYfgaJpZM4JkW5v
.

[holgerd]

I described the bug in separate issue #361

[lennerd]

👍 Thanks!

[lennerd]

FYI: Holger and I discussed the flow again and agreed on just fixing the current "Almost there" view without making the users email address mandatory.

[lennerd]

• Update new translations.

[lennerd]

@1000miles What do you think about deploying this on Staging? Does it make sense to deploy this now? Or should we wait for the new server setup.

[Xylakant]

go ahead and deploy on staging.

[Xylakant]

there's no reason not to continue development as normal, we're building fully parallel

[lennerd]

Didn't want to break something. Thanks for the information.

[lennerd]

@holgerd @Svenyo This is deployed on staging. Looking forward to your feedback.

@Svenyo I removed a source translation string and would like to push this to Transifex to update all other translation files. Okay?

[lennerd]

@holgerd @Svenyo Please review.

[holgerd]

This is still blocked by #361

[1000miles]

This may need to be deployed on staging again for @holgerd to review.

[holgerd]

@1000miles can you look into this and decide whether this can be resolved?

[holgerd]

@1000miles what is the status of this?

[1000miles]

@holgerd The sign-up/sign-in part was put on hold until the front-end part got a make-over by @opyh ? This is why this PR (#359) and the related issues (#175, #179) were assigned to you, or?

[holgerd]

@1000miles thanks. so this is on hold as well. :)